Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rowClass instead of collect #87

Conversation

vonbecmann
Copy link
Contributor

fix: #86
add SQLite3Column>>#cid: and SQLite3Column>>#notnull:
those accessor are use by the cursor to initialize the column

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (1592f72) 80.04% compared to head (0a08252) 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   80.04%   80.00%   -0.04%     
==========================================
  Files         108      108              
  Lines        4359     4356       -3     
==========================================
- Hits         3489     3485       -4     
- Misses        870      871       +1     
Files Changed Coverage Δ
src/SQLite3-Core/SQLite3Column.class.st 92.15% <100.00%> (-7.85%) ⬇️
src/SQLite3-Core/SQLite3Table.class.st 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astares astares merged commit a2ae6dd into pharo-rdbms:master Sep 21, 2023
@vonbecmann vonbecmann deleted the 86-use-SQLite3CursorrowClass-instead-of-collect branch September 21, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use SQLite3Cursor>>#rowClass instead of collect
2 participants