remove useless collect message send in SQLite3Table>>#rows. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-rdbms#71 and add some tests.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 79.02% 79.31% +0.28%
==========================================
Files 108 108
Lines 4473 4495 +22
==========================================
+ Hits 3535 3565 +30
+ Misses 938 930 -8
☔ View full report in Codecov by Sentry. |
astares
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
@vonbecmann
The test #testRowsHasOneRow overlaps with existing #testNumberOfRowsIsOne, but this is a minor issue. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #71
and add some tests.