Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use execute onlyValue in SQLite3Table>>#numberOfRows #70

Conversation

vonbecmann
Copy link
Contributor

use execute onlyValue in SQLite3Table>>#numberOfRows. and add some tests. fix: #69

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.29% 🎉

Comparison is base (f85b936) 78.73% compared to head (0baf880) 79.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   78.73%   79.02%   +0.29%     
==========================================
  Files         108      108              
  Lines        4454     4473      +19     
==========================================
+ Hits         3507     3535      +28     
+ Misses        947      938       -9     
Files Changed Coverage Δ
src/SQLite3-Core-Tests/SQLite3TableTest.class.st 100.00% <100.00%> (ø)
src/SQLite3-Core/SQLite3Database.class.st 68.75% <100.00%> (+1.64%) ⬆️
src/SQLite3-Core/SQLite3Table.class.st 87.09% <100.00%> (+9.31%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astares astares merged commit 1ad6c1d into pharo-rdbms:master Sep 6, 2023
@vonbecmann vonbecmann deleted the 69-use-execute-onlyValue-in-SQLite3TablenumberOfRows branch September 6, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use execute onlyValue in SQLite3Table>>#numberOfRows
2 participants