Experimental solution for step through interpreting the full flow issue #16351 #17308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change in SDL2 (libsdl-org/SDL@61cd57d) caused modifier changes to be sent as a repeat keydown with different key modifiers. This causes some keybindings to become un-typeable (For example: Cmd+Shift+W, E) because the keyup events cause these new keydown repeats with the new modifiers (for the previous example these are something like Cmd+Shift/Cmd+W/Shift+W).
…out repeat events. This feels like a hack...
- fix undo/redo cases that broke text, specially when in collaboration with the syntax highlighter - make undo/redo work on a word-by-word basis - make undo/redo restore selection and cursur when doing a replacement by paste/completion Co-authored-by: Fede Lochbaum <[email protected]>
…ugSession. These tests should be parametrized in the future. They are commited like this to ease the performance comparison between DebugSession and EnhancedDebugSession
Improvements in undo/redo
…vents Fix repeat events
Remove unnecessary KM repository reset
Fix typo: change "The cyclomatic complexity is heigh" to "The cyclomatic complexity is high"
…s-editor Major update of the Keymap Descriptions to a Shortcuts Editor
…t raise an exception in the interpreter but put a new context in it with the message send taken from the Smalltalk Special Array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not review yet
This is an experimental solution aimed at addressing issue#16351.
In it, an unknown bytecode is used to execute step through.
This is a work in progress, results and further steps will be analized with @tesonep
For performance comparison use the following code snippet