Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Shout #17247

Open
wants to merge 1 commit into
base: Pharo13
Choose a base branch
from
Open

Cleanup Shout #17247

wants to merge 1 commit into from
+8 −55

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Oct 10, 2024

  • Remove #stylingEnabled: because this is never used and if we do not want to style a text, we should not give it to the styler
  • Remove #text ivar that is unused
  • Remove #plugins that are unused

Fixes #16310

@jecisc
Cleanup Shout
f1ec7fd 
- Remove #stylingEnabled: because this is never used and if we do not want to style a text, we should not give it to the styler
- Remove #text ivar that is unused
- Remove #plugins that are unused

Fixes pharo-project#16310
@MarcusDenker
Copy link
Member

The plugins where added fairly recently, see #12429

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove plugins from Shout
2 participants
@jecisc @MarcusDenker