Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plugins from Shout #16310

Open
jecisc opened this issue Mar 18, 2024 · 1 comment · May be fixed by #17247
Open

Remove plugins from Shout #16310

jecisc opened this issue Mar 18, 2024 · 1 comment · May be fixed by #17247
Assignees
@jecisc
Labels
Type: Cleanup

Comments

@jecisc
Copy link
Member

jecisc commented Mar 18, 2024

In Shout we have a variable plugins but this is never used. This is dead code that we could remove.

Since we are in freeze phase I'm opening an issue instead of doing the change to remind me to do it when P13 branch will open
@jecisc jecisc self-assigned this Mar 18, 2024
jecisc added a commit to jecisc/pharo that referenced this issue Oct 10, 2024
@jecisc
Cleanup Shout
f1ec7fd 
- Remove #stylingEnabled: because this is never used and if we do not want to style a text, we should not give it to the styler
- Remove #text ivar that is unused
- Remove #plugins that are unused

Fixes pharo-project#16310
@jecisc jecisc linked a pull request Oct 10, 2024 that will close this issue
Open
@MarcusDenker
Copy link
Member

check with @estebanlm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jecisc jecisc

Labels
Type: Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup Shout jecisc/pharo
2 participants
@MarcusDenker @jecisc