Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use revert-taskit branch of mongotalk #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tinchodias
Copy link
Contributor

@tinchodias
Copy link
Contributor Author

@noha Do you think this rollback of taskit and use ad-hoc Process forks is worth a try?
(I mean if it runs well... this weekend I could see what are these errors on CI).

@noha
Copy link
Collaborator

noha commented May 17, 2021

I think it is worth solving the problem. I was unable to find the culprit in a short time frame so I'm open to many trials. There is too much going wrong for me with the new code. You did not answer the question if the voyage and mongo code is completely changed or if the old behaviour can still be activated

@tinchodias
Copy link
Contributor Author

@noha:

if the voyage and mongo code is completely changed or if the old behaviour can still be activated"

Right now, I don't remember when you asked it, but in any case. IIUC you ask me if VOMongoRepository could have like a "beSDAM" that switches to the MongoClient and else uses the previous system. My answer is that it's not direct change but may be possible, of course. When I moved to MongoClient, I also removed instance variables in VOMongoRepository and removed the VOMongoPool (not sure if was the exact name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants