forked from sonic-net/sonic-buildimage
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Administratively shutting down port channel will remove the ports fro…
…m trunk in the hardware and thereby traffic stops forwarding. sonic-net#1771
- Loading branch information
1 parent
f32243b
commit 7dcf099
Showing
2 changed files
with
26 additions
and
0 deletions.
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25
src/libteam/0013-teamd-lacp-port-admin-down-recv-not-processing.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c | ||
index 5fa026a..5f4ba75 100644 | ||
--- a/teamd/teamd_runner_lacp.c | ||
+++ b/teamd/teamd_runner_lacp.c | ||
@@ -1179,12 +1179,20 @@ static int lacpdu_recv(struct lacp_port *lacp_port) | ||
struct lacpdu lacpdu; | ||
struct sockaddr_ll ll_from; | ||
int err; | ||
+ bool admin_state; | ||
|
||
err = teamd_recvfrom(lacp_port->sock, &lacpdu, sizeof(lacpdu), 0, | ||
(struct sockaddr *) &ll_from, sizeof(ll_from)); | ||
if (err <= 0) | ||
return err; | ||
|
||
+ admin_state = team_get_ifinfo_admin_state(lacp_port->ctx->ifinfo); | ||
+ if (!admin_state) { | ||
+ teamd_log_info("%s received PDU in admin down state.", | ||
This comment has been minimized.
Sorry, something went wrong. |
||
+ lacp_port->tdport->ifname); | ||
+ return 0; | ||
+ } | ||
+ | ||
return lacpdu_process(lacp_port, &lacpdu); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd recommend to make it debug message. Otherwise we will create syslog message every 30 seconds on each member port of disabled port channel.