Skip to content

Commit

Permalink
Administratively shutting down port channel will remove the ports fro…
Browse files Browse the repository at this point in the history
…m trunk in the hardware and thereby traffic stops forwarding. sonic-net#1771
  • Loading branch information
phanindra-tv committed May 10, 2019
1 parent f32243b commit 7dcf099
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c
index 5fa026a..5f4ba75 100644
--- a/teamd/teamd_runner_lacp.c
+++ b/teamd/teamd_runner_lacp.c
@@ -1179,12 +1179,20 @@ static int lacpdu_recv(struct lacp_port *lacp_port)
struct lacpdu lacpdu;
struct sockaddr_ll ll_from;
int err;
+ bool admin_state;

err = teamd_recvfrom(lacp_port->sock, &lacpdu, sizeof(lacpdu), 0,
(struct sockaddr *) &ll_from, sizeof(ll_from));
if (err <= 0)
return err;

+ admin_state = team_get_ifinfo_admin_state(lacp_port->ctx->ifinfo);
+ if (!admin_state) {
+ teamd_log_info("%s received PDU in admin down state.",

This comment has been minimized.

Copy link
@pavel-shirshov

pavel-shirshov May 16, 2019

I'd recommend to make it debug message. Otherwise we will create syslog message every 30 seconds on each member port of disabled port channel.

+ lacp_port->tdport->ifname);
+ return 0;
+ }
+
return lacpdu_process(lacp_port, &lacpdu);
}

1 change: 1 addition & 0 deletions src/libteam/series
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
0010-teamd-lacp-update-port-state-according-to-partners-sy.patch
0011-libteam-resynchronize-ifinfo-after-lost-RTNLGRP_LINK-.patch
0012-teamd-do-not-process-lacpdu-before-the-port-ifinfo-i.patch
0013-teamd-lacp-port-admin-down-recv-not-processing.patch

0 comments on commit 7dcf099

Please sign in to comment.