Mirror upstream elastic/elasticsearch#134985 for AI review (snapshot of HEAD tree)

[phananh1010]

Single commit with tree=72ff6378adb9f7c324886609a94d425ba9e2edab^{tree}, parent=4a2d8fd40328763780fbefc32366456e1419b48b. Exact snapshot of upstream PR head. No conflict resolution attempted.

Summary by CodeRabbit

• Chores
  • Improved logging by downgrading certain error messages to warnings during transform operations.
  • Users will see fewer error-level logs when loading transform state or setting up destination indices and aliases; issues are still reported as warnings.
  • No functional changes—only log severity and verbosity were adjusted to reduce noise and prevent false alarms.

[coderabbitai]

Walkthrough

Log severity levels were changed from error to warn in two transform persistence classes. No control flow, API signatures, or listener behaviors were modified. Changes affect logging during exception paths for loading state and destination index/alias setup.

Changes

Cohort / File(s)	Summary of Changes
Transform persistence logging level updates x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/AuthorizationStatePersistenceUtils.java, x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/TransformIndex.java	Downgraded specific log statements from error to warn in exception paths (state load, destination index creation, alias setup). No logic, control flow, or public API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I twitch my ears at warnings mild,
No errors roar, just whispers filed.
Logs hop softly through the grass,
Same trails, same turns, they calmly pass.
A gentler thump—systems stay sound;
Carrots counted, peace profound. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title “Mirror upstream elastic#134985 for AI review (snapshot of HEAD tree)” describes the PR’s provenance rather than the actual code changes within, which mainly downgrade log levels from error to warn in transform persistence and index operations. It does not concisely summarize the primary change and is therefore unrelated to the content of the diff.	Please update the title to clearly describe the core change (e.g. “Downgrade transform error logs to warnings in persistence and index operations”) so that the main modifications are immediately understandable.
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch eval/pr-134985-diff

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a2d8fd and b3ae466.

📒 Files selected for processing (2)

• x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/AuthorizationStatePersistenceUtils.java (1 hunks)
• x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/TransformIndex.java (2 hunks)

🔇 Additional comments (1)

x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/AuthorizationStatePersistenceUtils.java (1)

131-135: Warn level is appropriate for load failures
Missing or non-existent state is already handled silently via onResponse(null). The remaining exceptions represent genuine failures (e.g. ES index issues), so logging at WARN appropriately surfaces them without marking them as fatal errors.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}