removed qodana; set up code coverage for sonar; renamed test classes

phalcon · Nov 18, 2024 · 5489104 · 5489104
1 parent 34733d0
commit 5489104
Show file tree

Hide file tree

Showing 9 changed files with 60 additions and 38 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -127,7 +127,7 @@ jobs:
       - run: composer install --prefer-dist
 
       - name: "Run Unit Tests"
-        run: vendor/bin/phpunit --coverage-clover=coverage.xml
+        run: composer test-coverage
 
       - name: SonarQube Cloud Scan
         uses: SonarSource/sonarcloud-github-action@master

diff --git a/composer.json b/composer.json
@@ -26,6 +26,7 @@
         "ext-mbstring": "*"
     },
     "require-dev": {
+        "pds/skeleton": "^1.0",
         "phalcon/ide-stubs": "^5.8",
         "phpstan/phpstan": "^1.11",
         "phpunit/phpunit": "^10.5",

diff --git a/composer.lock b/composer.lock
diff --git a/qodana.yaml b/qodana.yaml
diff --git a/sonar-project.properties b/sonar-project.properties
@@ -1,3 +1,20 @@
 sonar.projectKey=phalcon_volt
 sonar.organization=phalcon
-sonar.tests=tests
+
+sonar.sources=src/
+sonar.exclusions=vendor/**,cv/**,tests/**
+#sonar.inclusions=
+
+# Source encoding
+sonar.sourceEncoding=UTF-8
+
+sonar.language=php
+
+# Path to tests
+sonar.tests=tests/
+#sonar.test.exclusions=
+#sonar.test.inclusions=
+sonar.php.coverage.reportPaths=tests/support/coverage.xml
+
+# Exclusions for copy-paste detection
+#sonar.cpd.exclusions=
diff --git a/tests/unit/Compiler/CompileStringCest.php → tests/unit/Compiler/CompileStringTest.php b/tests/unit/Compiler/CompileStringCest.php → tests/unit/Compiler/CompileStringTest.php
@@ -17,7 +17,7 @@
 use Phalcon\Volt\Exception;
 use PHPUnit\Framework\TestCase;
 
-class CompileStringCest extends TestCase
+final class CompileStringTest extends TestCase
 {
     /**
      * Tests Phalcon\Mvc\View\Engine\Volt\Compiler :: compileString()

diff --git a/tests/unit/ExpressionCest.php → tests/unit/ExpressionTest.php b/tests/unit/ExpressionCest.php → tests/unit/ExpressionTest.php
@@ -16,7 +16,7 @@
 use Phalcon\Volt\Compiler;
 use PHPUnit\Framework\TestCase;
 
-final class ExpressionCest extends TestCase
+final class ExpressionTest extends TestCase
 {
     /**
      * Tests Phalcon\Mvc\View\Engine\Volt\Compiler :: expression()

diff --git a/tests/unit/FunctionCallCest.php → tests/unit/FunctionCallTest.php b/tests/unit/FunctionCallCest.php → tests/unit/FunctionCallTest.php
@@ -16,7 +16,7 @@
 use Phalcon\Volt\Compiler;
 use PHPUnit\Framework\TestCase;
 
-class FunctionCallCest extends TestCase
+final class FunctionCallTest extends TestCase
 {
     /**
      * @dataProvider getExamples

diff --git a/tests/unit/SetOptionCest.php → tests/unit/SetOptionTest.php b/tests/unit/SetOptionCest.php → tests/unit/SetOptionTest.php
@@ -16,7 +16,7 @@
 use Phalcon\Volt\Compiler;
 use PHPUnit\Framework\TestCase;
 
-final class SetOptionCest extends TestCase
+final class SetOptionTest extends TestCase
 {
     /**
      * Tests Phalcon\Mvc\View\Engine\Volt\Compiler :: setOption() - autoescape