T15098 Mvc\Model delete cascade relations with params #15126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altered fixtures to use params in relation
Added test for Mvc\Model::delete() with related items
|
I have a fix for this (#15098) for the 4.0.x branch as well, you can find it here: https://github.com/zsilbi/cphalcon/tree/T15098-related-cascade-delete |
…appen for hasOne relations)
zsilbi
force-pushed
the
T15098-related-cascade-delete-4.1.x
branch
from
419bc02 to
354ed04
Compare
ruudboon
approved these changes
Sep 2, 2020
Jeckerson
approved these changes
Sep 3, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Modified
Mvc\Model::_checkForeignKeysReverseCascade()to useModels\Manager::getRelationRecords()when deleting related records.Added tests for:
Mvc\Model::getRelated()andMvc\Model::delete()to ensure theparamsoption is used properly when accessing and deleting related models.Thanks,
zsilbi