-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor db tests #15076
Refactor db tests #15076
Conversation
@niden If you have time can you ping me to check how we can solve the sql db-lock? https://github.com/phalcon/cphalcon/runs/747581338?check_suite_focus=true#step:17:180 |
Sqlite does not like group statements, where etc. Anything "fast" i.e. tests running seems to lock the sqlite database. |
Ok, let's leave it open then. I will try to fix it or remove sqlite from these tests. |
Looks like connection to db is still open (maybe caused by a transaction?) |
@jenovateurs Do you have an idea what is causing this error?https://github.com/phalcon/cphalcon/pull/15076/checks?check_run_id=752726095#step:19:27 |
Hi @ruudboon, I think it's a type trouble. PostgreSQL is very strict about that.
These days, I have too much work to do. I haven't the time to debug line by line this code. |
@jenovateurs Thnx for your feedback. I expected some schema issues. But this is great feeback I will look into this. Thnx. |
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Refactored UniquenessCest