Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events manager fix #15045

Merged
merged 4 commits into from
May 19, 2020
Merged

Events manager fix #15045

merged 4 commits into from
May 19, 2020

Conversation

BeMySlaveDarlin
Copy link
Contributor

@BeMySlaveDarlin BeMySlaveDarlin commented May 19, 2020 •
edited
Loading

Hello!

  • Type: bug fix
  • Link to issue: #13322

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
There is a note in docs, saying that you can attach callable to events manager as event handler, but that doesn't works properly. Issue describing it.
Fixed in this PR. Now you can pass callable as event handler.

Thanks

@BeMySlaveDarlin BeMySlaveDarlin changed the base branch from master to 4.0.x May 19, 2020 16:17
@BeMySlaveDarlin BeMySlaveDarlin changed the title F/events manager fix Events manager fix May 19, 2020
Arhell
Arhell reviewed May 19, 2020
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the branch to 4.1.x
4.0.6 was the last

@BeMySlaveDarlin BeMySlaveDarlin changed the base branch from 4.0.x to 4.1.x May 19, 2020 17:39
@BeMySlaveDarlin
Copy link
Contributor Author

Please change the branch to 4.1.x
4.0.6 was the last

Done

@niden niden linked an issue May 19, 2020 that may be closed by this pull request
Event handlers should be also possible to be callable not just closures #13322
Closed
@niden niden merged commit 07d44d0 into phalcon:4.1.x May 19, 2020
@niden
Copy link
Member

niden commented May 19, 2020

@BeMySlaveDarlin Thank you for the contribution!

@niden niden added 4.1.0 documentation Documentation required new feature request Planned Feature or New Feature Request labels May 19, 2020
@niden niden mentioned this pull request May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

Assignees
No one assigned
Labels
documentation Documentation required new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event handlers should be also possible to be callable not just closures
3 participants
@BeMySlaveDarlin @niden @Arhell