Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed return type hint for Model::getEventsManager #15009

Merged
merged 3 commits into from
May 5, 2020
Merged

Changed return type hint for Model::getEventsManager #15009

merged 3 commits into from
May 5, 2020

Conversation

sergeyklay
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

  • Changed return type hint for Phalcon\Mvc\Model\Manager::getCustomEventsManager to return NULL instead of boolean FALSE if there is no special events manager
  • Fixed return type hint for Phalcon\Mvc\Model::getEventsManager to reflect original behavior

Thanks

@sergeyklay sergeyklay self-assigned this May 5, 2020
@sergeyklay sergeyklay linked an issue May 5, 2020 that may be closed by this pull request
[BUG]: Incorrect return type hint of Phalcon\Mvc\Model::getEventsManager() #15008
Closed
niden
niden requested changes May 5, 2020
View reviewed changes
Copy link
Member

@niden niden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change

tests/database/Mvc/Model/GetSetEventsManagerCest.php Outdated Show resolved Hide resolved
@sergeyklay sergeyklay merged commit 45ee3a4 into 4.0.x May 5, 2020
@sergeyklay sergeyklay deleted the fix/model-events-manager-return-type-hint branch May 5, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees

@sergeyklay sergeyklay

Labels
bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Incorrect return type hint of Phalcon\Mvc\Model::getEventsManager()
2 participants
@sergeyklay @niden