Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return type for CriteriaInterface::getLimit #15005

Merged
merged 2 commits into from
May 4, 2020
Merged

Conversation

sergeyklay
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

  • Changed return type for Phalcon\Mvc\Model\Criteria::getLimit so that integer, NULL or array will be returned
  • Fixed return type hint for Phalcon\Mvc\Model\CriteriaInterface::getLimit and Phalcon\Mvc\Model\Criteria::getLimit to follow documentation and original purpose
    Thanks

@niden niden added bug A bug report status: low Low labels May 4, 2020
@niden
Copy link
Member

niden commented May 4, 2020

LGTM

@sergeyklay sergeyklay merged commit 3691c7f into 4.0.x May 4, 2020
@sergeyklay sergeyklay deleted the fix/criteria-limit branch May 4, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Incorrect return type hint of Phalcon\Mvc\Model\CriteriaInterface::getLimit()
2 participants