Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return type hint for Di::getInternalEventsManager #14993

Merged
merged 1 commit into from
May 3, 2020

Conversation

sergeyklay
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

  • Fixed return type hint for Phalcon\Di::getInternalEventsManager
  • Changed default value for Phalcon\Di::getInternalEventsManager:$services to empty array
  • Changed default value for Phalcon\Di::getInternalEventsManager:$sharedInstances to empty array
  • Adjusted tests

Thanks

@sergeyklay sergeyklay self-assigned this May 3, 2020
@sergeyklay sergeyklay linked an issue May 3, 2020 that may be closed by this pull request
@sergeyklay sergeyklay merged commit 24857a7 into 4.0.x May 3, 2020
@sergeyklay sergeyklay deleted the fix/di-internal-events-manager branch May 3, 2020 11:52
@sergeyklay sergeyklay added status: low Low bug A bug report labels May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Wrong return type for Phalcon\Di::getInternalEventsManager
1 participant