Remove underscore prefix in methods

[Jeckerson]

Hello!

• Type: new feature | code quality
• Link to issue:

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Removed underscores in protected and extendable (not final) methods to be PSR-12 compliant.

Thanks

[sergeyklay]

/cc @phalcon/core-team

[niden]

We cannot do this now. It breaks backwards compatibility. If it was only private methods that would be fine but since it touches protected methods it will break applications that extend these classes and use those methods.

We can put a @todo on this for v5

[sergeyklay]

Is there any place where we can start collect things for v5?

[niden]

Lets make a small change here so that this can be merged safely without breaking BC.

Leave the underscore named methods where they are. Copy each of those methods to new ones without the underscore. From the one with the underscore, call the other one without. The underscore named methods become proxy ones. Add a @todo or @deprecated in the docblock of the underscore one so that we can remove those in v5.

This way we do what we need but also keep BC

[ruudboon]

@Jeckerson If you have time can you rebase and have look at the requested changes?

[ruudboon]

Please add the BC methods

[Jeckerson]

Will try to add it during today.

[ruudboon]

I would like to suggest to implement to logic in the methods that are going to be in v5.
Now we are getting extra unnecessary look ups groupResult() calls _groupResult() and it will be easier when cleaning up the deprecated methods.

[zsilbi]

I think this is going to break BC this way, because the logic is not quite right.

For example, if someone had custom a _postSaveRelatedRecords() implemented in their Model before, it's not going to be ever called by the Model itself after a save because it will only call the new function (postSaveRelatedRecords()) instead.

namespace My;

class Model extends \Phalcon\Mvc\Model {
   /**
    * My custom _postSaveRelatedRecords implementation
    */
   protected function _postSaveRelatedRecords(AdapterInterface $connection, $related): bool {
      // This won't be ever called by Model

      return parent::_postSaveRelatedRecords($connection, $related);
   }
}

Following this example, this solution only applies to those, who originally had Model::_postSaveRelatedRecords() calls in their Model for some reason.

namespace My;

class Model extends \Phalcon\Mvc\Model {
   /**
     * My custom function
     * 
     * @throws Exception
     * @throws Model\Exception
     */
    public function doSomething(): void
    {
        // This will work, thanks to the proxy function
        $this->_postSaveRelatedRecords(
            $this->getWriteConnection(),
            $this->dirtyRelated
        );
    }
}