#13655 - Assets/Collection - Tests finished - Just 2 errors in Phalcon

[jenovateurs]

Hi team!
I have a new delivery of test.
Assets/Collection is done.
But I have 3 problems :

• GitHub display a message : " Can’t automatically merge. Don’t worry, you can still create the pull request. " - I don't know how to solved it.
• The test Assets/Collection/CurrentCest trigger an error because the variable "position" is not initialize in Phalcon (Error : phalcon/Assets/Collection.zep on line 261)
• I have the same problem with Asset/Collection/ValidCest, I can't valid my CSS file because "position" is not initialize.

Thanks for your help ;-)

• Type: code quality
• Link to issue: Refactor Unit Tests - Add more tests #13655

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Thanks

[Jeckerson]

" Can’t automatically merge. Don’t worry, you can still create the pull request. " - I don't know how to solved it.

You need to rebase your branch with latest commits from 4.0.x

[Jeckerson]

The test Assets/Collection/CurrentCest trigger an error because the variable "position" is not initialize in Phalcon (Error : phalcon/Assets/Collection.zep on line 261)

You can try to set default value:
protected position = 0 { get };

https://github.com/phalcon/cphalcon/blob/master/phalcon/Assets/Collection.zep#L74

[jenovateurs]

@Jeckerson Thanks for your help ;-)