Annotations router custom action pre-format callback #14819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeMySlaveDarlin
requested review from
Jeckerson,
niden,
ruudboon,
sergeyklay and
SidRoberts
Jeckerson
approved these changes
Feb 5, 2020
niden
added
4.1.0
documentation
niden
previously approved these changes
Feb 5, 2020
niden
requested changes
Feb 5, 2020
There was a problem hiding this comment.
@BeMySlaveDarlin could you please update the 4.1 changelog with this functionality?
Other than that this is ready
Looks like it was lost through rebase. Added. |
niden
approved these changes
Feb 5, 2020
|
Thank you @BeMySlaveDarlin |
BeMySlaveDarlin
deleted the
f/annotations-router-custom-action-preformat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Added method to set callback handler to pre-format action name in Annotation Router.
Default behavior of action name processing:
PostsController::getLastUpdatedAction()equals to uri/posts/getlastupdatedvia strtolower formatting.New behavior allows to set callback, which does user defined pre-format to action name:
PostsController::getLastUpdatedAction()equals to uri/posts/get-last-updatedvia uncamelize passed as callbackThanks