#14801 - Phalcon\Helper\Arr::blackList() #14808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #14802 as well |
|
Can you sent it to the 4.1.x branch? |
Oh my god, i'm sorry
There's a lot of conflict. |
ruudboon
requested changes
Feb 4, 2020
CHANGELOG-4.0.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| # [4.0.3](https://github.com/phalcon/cphalcon/releases/tag/v4.0.3) (2020-01-25) | |||
| ## Added | |||
| - Added `Phalcon\Helper\Arr::blackList()` to exclude elements of an array by the keys obtained from the elements of a blacklist [#14801](https://github.com/phalcon/cphalcon/issues/14801) [@TimurFlush](https://github.com/TimurFlush) | |||
There was a problem hiding this comment.
Please add this to the CHANGELOG-4.1.md
This reverts commit 16b8775.
Codecov Report
@@ Coverage Diff @@
## master #14808 +/- ##
==========================================
+ Coverage 67.99% 68% +<.01%
==========================================
Files 483 483
Lines 111463 111479 +16
==========================================
+ Hits 75789 75808 +19
+ Misses 35674 35671 -3 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Thanks