Minor changes on Stream adapter

[ekmst]

Hello!

• Type: code quality | enhancement | bugfix
• Link to issue: [BUG]: A directory that does not exist when using a prefix and with empty data #14725

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Small description of change:

I could not reproduce this problem(#14714), but I think this will solve it.

Even if this does not help, I think this improvement will not be superfluous :)

Thanks

[codecov]

Codecov Report

Merging #14721 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14721      +/-   ##
==========================================
+ Coverage   67.97%   67.97%   +<.01%     
==========================================
  Files         483      483              
  Lines      111473   111435      -38     
==========================================
- Hits        75773    75749      -24     
+ Misses      35700    35686      -14

[ruudboon]

@ekmst Can you add a test for this?

[ekmst]

@ruudboon Existing tests pass and I did not add.

Ok, add later

[ekmst]

I caught another bug when writing tests.
If we call the Stream::getKeys() method with empty data and using a prefix, we get an exception. The following is an example for this behavior:

$serializer = new \Phalcon\Storage\SerializerFactory();

$adapter = new \Phalcon\Cache\Adapter\Stream(
    $serializer,
    [
        'storageDir' => '/tmp/',
        'prefix'     => 'pref-',       // The '/tmp/pref-' directory will not be created until we have written any data
    ]
);
$adapter->getKeys();  // Throws an exception

We get an exception:

Fatal error: Uncaught UnexpectedValueException: RecursiveDirectoryIterator::__construct(/tmp/pref-/): failed to open dir: No such file or directory in ...

[ruudboon]

I caught another mistake when writing tests.
If we call the Stream::getKeys() method with empty data and using a prefix, we get an exception. The following is an example for this behavior:

$serializer = new \Phalcon\Storage\SerializerFactory();

$adapter = new \Phalcon\Cache\Adapter\Stream(
    $serializer,
    [
        'storageDir' => '/tmp/',
        'prefix'     => 'pref-',       // The '/tmp/pref-' directory will not be created until we have written any data
    ]
);
$adapter->getKeys();  // Throws an exception

We get an exception:

Fatal error: Uncaught UnexpectedValueException: RecursiveDirectoryIterator::__construct(/tmp/pref-/): failed to open dir: No such file or directory in ...

Let's handle that in a new issue.

[ekmst]

Let's handle that in a new issue.

@ruudboon
Done

[ruudboon]

@ekmst Thank you

[ruudboon]

Please don't merge this yet. Looks like Travis missed this pull

[ekmst]

@ruudboon
In the last commit, only the change log was updated, so I explicitly skipped the building([skip ci]).

The build was in the previous commit
https://ci.appveyor.com/project/sergeyklay/cphalcon/builds/30181621
and
https://travis-ci.org/phalcon/cphalcon/builds/638377382?utm_source=github_status&utm_medium=notification

[ruudboon]

@ekmst Sorry. I was sleeping ;)

[ekmst]

@ruudboon no problem :)

[niden]

Thank you @ekmst !