Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14602 setcookies #14604

Merged
merged 5 commits into from
Dec 9, 2019
Merged

T14602 setcookies #14604

merged 5 commits into from
Dec 9, 2019

Conversation

niden
Copy link
Member

@niden niden commented Dec 8, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Http\CookieInterface to Phalcon\Http\Cookie\CookieInterface to avoid confusion
Fixed Phalcon\Http\Response::setCookies to use the correct interface

Thanks

@niden niden added 4.0 labels Dec 8, 2019
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #14604 into 4.0.x will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14604      +/-   ##
==========================================
+ Coverage   67.75%   67.79%   +0.03%     
==========================================
  Files         489      488       -1     
  Lines      112712   112709       -3     
==========================================
+ Hits        76372    76407      +35     
+ Misses      36340    36302      -38

@niden niden merged commit 4701b76 into phalcon:4.0.x Dec 9, 2019
@niden niden deleted the T14602-setcookies branch December 9, 2019 00:44
use UnitTester;
use function var_dump;
Copy link
Member

@ruudboon ruudboon Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niden Only seeing this now. I think it can go.
Never mind this was already catched.

@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants