Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Http\Response tests delivery #14603

Merged
merged 21 commits into from
Dec 8, 2019
Merged

Small Http\Response tests delivery #14603

merged 21 commits into from
Dec 8, 2019

Conversation

jenovateurs
Copy link
Contributor

@jenovateurs jenovateurs commented Dec 8, 2019 •
edited
Loading

Hello!

I did some tests, some merges with old ones and I hope it's OK.
Here are the new tests for Http\Response:

  • construct()
  • get/setContent()
  • get/setStatusCode()
  • get/setHeaders()
  • getReasonPhrase()
  • get/setCookies() -> Like I said in [BUG]: Http\Response can't setCookies #14602, I've had trouble with Cookies which do not exist.
  • isSent()
  • setExpires()
  • get/setHeaders()
  • setLastModified()
  • setJsonContent()

Thanks for your review and comments :-).

@jenovateurs @niden
Test Phalcon\Http\Response :: setJsonContent()
694e09d 
Check if the content, the header is ok. Also test Json option.
@jenovateurs @niden
Add 3 tests to check Http\Response constructor
77a3749 
* Check without parameters
* Check with content
* Check with code
* Check with code and status
@jenovateurs @niden
Test - Check Get/SetContent of Http\Response
2a2d207
@jenovateurs @niden
Delete SetContentCest.php
6b6b265 
Test is in GetSetContentCest.php
@jenovateurs @niden
Test - Get/SetStatusCode of Http\Response
3eccccb
@jenovateurs @niden
Delete SetStatusCodeCest.php
d8aee60 
Test is in GetSetStatusCodeCest.php
@jenovateurs @niden
Test Get/SetHeaders of Http\Response
2b92600
@jenovateurs @niden
Delete SetHeadersCest.php
60d22f9 
Test in GetSetHeadersCest.php
@jenovateurs @niden
Test - getReasonPhrase of Http\Response
63f2ecb
@jenovateurs @niden
Update GetReasonPhraseCest.php
c812def
@jenovateurs @niden
Test : get/setCookies of Http\Response
d8d83ad
@jenovateurs @niden
Delete SetCookiesCest.php
9110e09 
Test is in GetSetCookiesCest.php
@jenovateurs @niden
Update GetSetCookiesCest.php
60e953e
@jenovateurs @niden
Test isSent() of Http\Response
967d0cd
@jenovateurs @niden
Test setExpires of Http\Response
a8ec93a
@jenovateurs @niden
Update IsSentCest.php
87e8360
@jenovateurs @niden
Add old test in GetSetStatusCode
d50ee71
@jenovateurs @niden
Update GetSetStatusCodeCest.php
9a6b59a
@jenovateurs @niden
Update GetSetHeadersCest.php
5384b6f
@jenovateurs @niden
Test setLastModified of Http\Response
1737141
@niden niden added 4.0 labels Dec 8, 2019
@niden niden merged commit 814efea into phalcon:4.0.x Dec 8, 2019
@niden
Copy link
Member

niden commented Dec 8, 2019

Thank you @jenovateurs

@niden niden added the bug A bug report label Dec 23, 2019
@niden niden added status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees
No one assigned
Labels
bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenovateurs @niden