Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14488 column map #14566

Merged
merged 3 commits into from
Dec 1, 2019
Merged

T14488 column map #14566

merged 3 commits into from
Dec 1, 2019

Conversation

niden
Copy link
Member

@niden niden commented Dec 1, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\Model::cloneResultMap to correctly recognize aliased fields and include them in the resultset

Thanks

@niden niden added 4.0 labels Dec 1, 2019
@codecov
Copy link

codecov bot commented Dec 1, 2019

Codecov Report

Merging #14566 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14566      +/-   ##
==========================================
- Coverage   67.73%   67.73%   -0.01%     
==========================================
  Files         488      488              
  Lines      112557   112566       +9     
==========================================
+ Hits        76243    76249       +6     
- Misses      36314    36317       +3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants