Returning Instead Of Breaking - Stop Processing Additional View Directories

[Fenikkusu]

Hello!

• Type: bug fix
• Link to issue: Rendering stages get multiplied when viewDirs is an array #12977 | [2.1 RC1] When using multiple directories in setViewsDir, views with same name are rendered for each dir #11633

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Small description of change:

If you specify multiple view directories using, it creates an abnormality where the same file will be included from every view directory it exists. Rather than continuing the view directory loop, this breaks out of the function completely.

Thanks

[niden]

cc @maurits150 @memmaker - thanks to the original reporters of this.

[codecov]

Codecov Report

Merging #14526 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14526      +/-   ##
==========================================
+ Coverage   67.71%   67.71%   +<.01%     
==========================================
  Files         481      481              
  Lines      111827   111820       -7     
==========================================
- Hits        75719    75715       -4     
+ Misses      36108    36105       -3

[Fenikkusu]

I'll get the testing added in tomorrow.

[maurits150]

I guess that notExists can be removed now that you always return when a view is found.

[Fenikkusu]

I've added the testing in for this. Additionally, per @maurits150 , I have also removed the notExists boolean as it isn't needed anymore. I also went ahead and updated the change log.

[niden]

Excellent work. Thank you @Fenikkusu and @maurits150 for the implementation and input