Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Model\Manager::getRelations() and getRelationsBetween() #14509

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

zsilbi
Copy link
Member

@zsilbi zsilbi commented Nov 3, 2019

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Fixed Phalcon\Mvc\Model\Manager::getRelations() and getRelationsBetween() to return many-to-many relations correctly.

Thanks,
zsilbi

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #14509 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14509      +/-   ##
==========================================
+ Coverage   67.69%   67.69%   +<.01%     
==========================================
  Files         482      482              
  Lines      111758   111763       +5     
==========================================
+ Hits        75659    75663       +4     
- Misses      36099    36100       +1

niden
niden previously approved these changes Nov 4, 2019
@niden
Copy link
Member

niden commented Nov 4, 2019

@zsilbi When you get a chance can you rebase this please?

@zsilbi zsilbi requested a review from niden November 5, 2019 14:07
@niden niden added 4.0 labels Nov 5, 2019
@niden niden merged commit 330e285 into phalcon:4.0.x Nov 5, 2019
@niden
Copy link
Member

niden commented Nov 5, 2019

Thank you @zsilbi

@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
@zsilbi zsilbi deleted the model-bugfixes branch March 2, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants