Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14408 - Corrections to serializers and notices they throw #14431

Merged
merged 4 commits into from
Sep 29, 2019
Merged

14408 - Corrections to serializers and notices they throw #14431

merged 4 commits into from
Sep 29, 2019

Conversation

niden
Copy link
Member

@niden niden commented Sep 29, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed the code to trap exceptions/notices for serializers as well as fopen for stream.

Thanks

@niden niden added 4.0 labels Sep 29, 2019
@niden
Copy link
Member Author

niden commented Sep 29, 2019

cc @sergeyklay @ruudboon

@niden niden mentioned this pull request Sep 29, 2019
5 tasks
@codecov
Copy link

codecov bot commented Sep 29, 2019

Codecov Report

Merging #14431 into 4.0.x will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14431      +/-   ##
==========================================
+ Coverage   67.65%   67.68%   +0.02%     
==========================================
  Files         478      478              
  Lines      110956   110969      +13     
==========================================
+ Hits        75066    75106      +40     
+ Misses      35890    35863      -27

@ruudboon
Copy link
Member

Looks good. thnx

@niden niden merged commit f2211e7 into phalcon:4.0.x Sep 29, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants