Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixes (code quality) #14407

Merged
merged 15 commits into from
Sep 24, 2019
2 changes: 1 addition & 1 deletion phalcon/Application/AbstractApplication.zep
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ abstract class AbstractApplication extends Injectable implements EventsAwareInte
/**
* Handles a request
*/
abstract public function handle();
abstract public function handle(string! uri) -> <ResponseInterface> | bool;
sergeyklay marked this conversation as resolved.
Show resolved Hide resolved

/**
* Register an array of modules present in the application
Expand Down
2 changes: 1 addition & 1 deletion phalcon/Cli/Console.zep
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class Console extends AbstractApplication
/**
* Handle the whole command-line tasks
*/
public function handle(array arguments = null)
public function handle(string! arguments) -> <ResponseInterface> | bool
sergeyklay marked this conversation as resolved.
Show resolved Hide resolved
{
var className, container, dispatcher, eventsManager, module, moduleName,
moduleObject, modules, path, router, task;
Expand Down
2 changes: 1 addition & 1 deletion phalcon/Factory/AbstractFactory.zep
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace Phalcon\Factory;
use Phalcon\Config;
use Phalcon\Factory\Exception;

class AbstractFactory
abstract class AbstractFactory
{
/**
* @var array
Expand Down
7 changes: 4 additions & 3 deletions phalcon/Helper/Fs.zep
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ namespace Phalcon\Helper;
/**
* This class offers file operation helper
*/
class Fs {
class Fs
{

/**
* Gets the filename from a given path, Same as PHP's basename() but has non-ASCII support.
Expand All @@ -30,8 +31,8 @@ class Fs {
var filename, matches;
let uri = rtrim(uri, DIRECTORY_SEPARATOR);
let filename = preg_match(
"@[^" . preg_quote(DIRECTORY_SEPARATOR, "@") . "]+$@",
uri,
"@[^" . preg_quote(DIRECTORY_SEPARATOR, "@") . "]+$@",
uri,
matches
) ? matches[0] : "";
if suffix {
Expand Down
2 changes: 1 addition & 1 deletion phalcon/Http/RequestInterface.zep
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ interface RequestInterface
* @param bool onlyPath If true, query part will be omitted
* @return string
*/
final public function getURI(bool onlyPath = false) -> string;
public function getURI(bool onlyPath = false) -> string;

/**
* Gets a variable from the $_POST superglobal applying filters if needed
Expand Down
1 change: 0 additions & 1 deletion phalcon/Mvc/Model.zep
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ use Phalcon\Mvc\Model\TransactionInterface;
use Phalcon\Mvc\Model\ValidationFailed;
use Phalcon\Mvc\ModelInterface;
use Phalcon\Validation\ValidationInterface;
use Phalcon\Events\ManagerInterface as EventsManagerInterface;
use Serializable;

/**
Expand Down
2 changes: 1 addition & 1 deletion phalcon/Mvc/Model/ManagerInterface.zep
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ interface ManagerInterface
* );
* ```
*/
final public function isVisibleModelProperty(<ModelInterface> model, string property) -> bool;
public function isVisibleModelProperty(<ModelInterface> model, string property) -> bool;

/**
* Sets if a model must keep snapshots
Expand Down