-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Passback To DIC #14342
Merged
Merged
Adding Passback To DIC #14342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14342 +/- ##
==========================================
- Coverage 67.78% 67.77% -0.01%
==========================================
Files 478 478
Lines 112924 112927 +3
==========================================
- Hits 76549 76541 -8
- Misses 36375 36386 +11 |
Related to #13042 |
sergeyklay
added
4.1
new feature request
Planned Feature or New Feature Request
discussion
Request for comments and discussion
labels
Aug 29, 2019
/cc @phalcon/framework-team |
niden
previously approved these changes
Sep 7, 2019
@Fenikkusu could you please add an entry in the CHANGELOG-4.0 please? |
and rebase |
Fenikkusu
force-pushed
the
4.0.x-di-alias
branch
from
September 8, 2019 21:44
19b9868
to
772a002
Compare
Done |
sergeyklay
previously approved these changes
Sep 9, 2019
ruudboon
previously approved these changes
Sep 9, 2019
Jeckerson
previously approved these changes
Sep 9, 2019
Fenikkusu
dismissed stale reviews from Jeckerson, ruudboon, and sergeyklay
via
September 11, 2019 00:42
0e1b3e8
sergeyklay
approved these changes
Sep 11, 2019
ruudboon
approved these changes
Sep 11, 2019
@Fenikkusu Thank you! |
niden
added
documentation
Documentation required
and removed
discussion
Request for comments and discussion
labels
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
I often find myself having to do the following:
This PR eliminates the extra steps by letting the service class instantiate through the DIC. I can now right the code as:
Thanks