Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #14265 #14336

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Fixed issue #14265 #14336

merged 1 commit into from
Aug 27, 2019

Conversation

ruudboon
Copy link
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Switch to first implementation. Ignoring params in open.

@ruudboon ruudboon requested a review from sergeyklay August 27, 2019 14:54
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #14336 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14336      +/-   ##
==========================================
- Coverage   66.31%    66.3%   -0.01%     
==========================================
  Files         488      488              
  Lines      115910   115903       -7     
==========================================
- Hits        76862    76855       -7     
  Misses      39048    39048

@sergeyklay sergeyklay merged commit 8ed84b0 into phalcon:4.0.x Aug 27, 2019
@sergeyklay
Copy link
Contributor

Thank you

@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants