Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 14263 #14312

Merged
merged 5 commits into from
Aug 19, 2019
Merged

Fixed issue 14263 #14312

merged 5 commits into from
Aug 19, 2019

Conversation

ruudboon
Copy link
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG

Small description of change:
Moved logger to correct namespace.

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #14312 into 4.0.x will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            4.0.x   #14312     +/-   ##
=========================================
- Coverage   66.31%   66.21%   -0.1%     
=========================================
  Files         488      487      -1     
  Lines      115913   115462    -451     
=========================================
- Hits        76862    76458    -404     
+ Misses      39051    39004     -47

Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove old files:

  • ext/phalcon/logger/logger.zep.c
  • ext/phalcon/logger/logger.zep.h

This is why AppVeyor failed

@ruudboon
Copy link
Member Author

Please remove old files:

  • ext/phalcon/logger/logger.zep.c
  • ext/phalcon/logger/logger.zep.h

This is why AppVeyor failed

Thnx, that makes sense.

@sergeyklay sergeyklay merged commit 6e0e1bb into phalcon:4.0.x Aug 19, 2019
@sergeyklay
Copy link
Contributor

Thank you

@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants