Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14293 application interface correction #14298

Merged
merged 3 commits into from
Aug 14, 2019
Merged

T14293 application interface correction #14298

merged 3 commits into from
Aug 14, 2019

Conversation

niden
Copy link
Member

@niden niden commented Aug 14, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Corrected interfaces

Thanks

@niden niden changed the base branch from master to 4.0.x August 14, 2019 14:07
@niden niden added 4.0 labels Aug 14, 2019
@niden
Copy link
Member Author

niden commented Aug 14, 2019

cc @sergeyklay

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #14298 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            4.0.x   #14298   +/-   ##
=======================================
  Coverage    66.3%    66.3%           
=======================================
  Files         488      488           
  Lines      115910   115910           
=======================================
  Hits        76859    76859           
  Misses      39051    39051

@sergeyklay sergeyklay merged commit d0216f3 into phalcon:4.0.x Aug 14, 2019
@sergeyklay
Copy link
Contributor

Well done!

@niden niden deleted the T14293-application-interface-correction branch September 12, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants