-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new mongodb driver #14230
Feature/new mongodb driver #14230
Conversation
@tacxticx88 Could you please rebase. I've installed mongodb extension in #14236 |
Co-Authored-By: Serghei Iakovlev <[email protected]>
What is this waiting on? |
@tacxticx88 Can you fix the 2 line enters to pass the last test and update the changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor questions I would like understand to. Also we'll need update change log (see my comments). But at the moment it seems good to me.
Co-Authored-By: Serghei Iakovlev <[email protected]>
@tacxticx88 If you have time can you rebase your branch to see where we stand? |
@ruudboon I'll do that. Yes, my work was moved to a private storage facility before the switch to Phalcon v4. |
@tacxticx88 We're currently upgrading our testsuite as well. If you need some help rewriting the test let us know. |
@tacxticx88 Any news on this? If you have time to work on this can you switch to the 4.1.x branch? thnx |
Mentioning this one more time just in case. For this PR to work and to be part of core, we need to ensure that it does not reference any classes or interfaces that a different extension has (in this case the php mongo extension). Doing so will require that extension to be loaded first before Phalcon even starts. Example is the PSR extension which is now a requirement for Phalcon to work. |
Hello, I'm currently looking for a solution to this problem because the Collection class should implement the interface of MongoDb to be able to automatically caste the model and its child classes.. |
I suggest to finally write the ODM in PHP in order to take advantage of MongoDb's Composer repository. In my case the work is already well advanced. What do you think of that? MongoDb having its driver written mostly in PHP. |
@tacxticx88 I think that might be the best solution at least for the time being until we regroup and figure out a way to solve the technical issues that will appear by including the mongo interfaces in the core. We can set up an incubator repository and all the work and support can go there. People will then be able to add the component using composer. Maybe later on we can include this functionality with FFI in the core or something similar - not sure now just thinking out loud. I agree, we need to get this done in the incubator. |
@tacxticx88 Do you agree on closing this one? |
Yes. See the new phalcon/incobator-mongodb repository |
Closing this in favour of the new https://github.com/phalcon/incubator-mongodb repo |
Hello!
In raising this pull request, I confirm the following:
Phalcon\Mvc\Collection\Document::__construct()
Phalcon\Mvc\Collection\Document::count()
Phalcon\Mvc\Collection\Document
Countable
Phalcon\Mvc\Collection::findFirst()
null
orCollectionInterface
Phalcon\Mvc\Collection::getId()
\MongoDB\BSON\ObjectId
Phalcon\Mvc\Collection::createIfNotExist()
Phalcon\Mvc\Collection::summatory()
Phalcon\Mvc\Collection::aggregate()
method.Phalcon\Mvc\Collection\Manager::getCustomEventsManager()
null
orPhalcon\Events\ManagerInterface
Phalcon\Mvc\Collection\Manager::getConnection()
\MongoDB\Database
orPhalcon\Db\Adapter\AdapterInterface
Phalcon\Mvc\Collection\Manager
collection:
instead ofmodel:
var model
tovar collection
)Phalcon\Mvc\Collection
MongoId
to the new typeObjectId
var mongoId
tovar objectId
)Thanks