Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T14213 abstract classes #14228

Merged
merged 58 commits into from
Jul 4, 2019
Merged

T14213 abstract classes #14228

merged 58 commits into from
Jul 4, 2019

Conversation

niden
Copy link
Member

@niden niden commented Jul 2, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines

  • I have checked that another pull request for this purpose does not exist

  • I wrote some tests for this PR

  • I have updated the relevant CHANGELOG

  • I have created a PR for the documentation about this change

  • Added Phalcon\Db\Enum

  • Added Phalcon\Dispatcher\Exception

  • Renamed Phalcon\Acl to Phalcon\Acl\Enum

  • Renamed Phalcon\Acl\Adapter to Phalcon\Acl\Adapter\AbstractAdapter

  • Renamed Phalcon\Acl\AdapterInterface to Phalcon\Acl\Adapter\AdapterInterface

  • Renamed Phalcon\Application to Phalcon\Application\AbstractApplication

  • Renamed Phalcon\Container to Phalcon\Container\Container

  • Renamed Phalcon\Crypt to Phalcon\Crypt\Crypt

  • Renamed Phalcon\CryptInterface to Phalcon\Crypt\CryptInterface

  • Renamed Phalcon\Db\Adapter to Phalcon\Db\Adapter\AbstractAdapter

  • Renamed Phalcon\Db\AdapterInterface to Phalcon\Db\Adapter\AdapterInterface

  • Renamed Phalcon\Db to Phalcon\Db\AdapterDb

  • Renamed Phalcon\Db\Adapter\Pdo to Phalcon\Db\Adapter\Pdo\AbstractPdo

  • Renamed Phalcon\Dispatcher to Phalcon\Dispatcher\AbstractDispatcher

  • Renamed Phalcon\DispatcherInterface to Phalcon\Dispatcher\DispatcherInterface

  • Renamed Phalcon\Escaper to Phalcon\Escaper\Escaper

  • Renamed Phalcon\EscaperInterface to Phalcon\Escaper\EscaperInterface

  • Renamed Phalcon\Firewall\Adapter to Phalcon\Firewall\Adapter\AbstractAdapter

  • Renamed Phalcon\Firewall\AdapterInterface to Phalcon\Firewall\Adapter\AdapterInterface

  • Renamed Phalcon\Flash to Phalcon\Flash\AbstractFlash

  • Renamed Phalcon\FlashInterface to Phalcon\Flash\FlashInterface

  • Renamed Phalcon\Forms\Element to Phalcon\Forms\Element\AbstractElement

  • Renamed Phalcon\Forms\ElementInterface to Phalcon\Forms\Element\ElementInterface

  • Renamed Phalcon\Image to Phalcon\Image\Enum

  • Renamed Phalcon\Mvc\View\Engine to Phalcon\Mvc\View\Engine\AbstractEngine

  • Renamed Phalcon\Mvc\View\EngineInterface to Phalcon\Mvc\View\Engine\EngineInterface

  • Renamed Phalcon\Security to Phalcon\Security\Security

  • Renamed Phalcon\Validator to Phalcon\Validator\Validator

  • Renamed Phalcon\Validator\Validator to Phalcon\Validator\AbstractValidator

  • Renamed Phalcon\Validator\ValidatorComposite to Phalcon\Validator\AbstractValidatorComposite

  • Renamed Phalcon\Validator\CombinedFieldsValidator to Phalcon\Validator\AbstractCombinedFields

  • Renamed Phalcon\Validator\Validator\File\FileAbstract to Phalcon\Validator\Validator\File\AbstractFile

Thanks

niden added 30 commits July 1, 2019 21:42
@niden
Printout correction
aadafd4
@niden
Renaming abstract classes WIP
887ec09
@niden
[#14213] - Moved Container to its own folder; Renamed abstract firewa…
6cfd011 
…ll classes
@niden
[#14213] - Removed abstract from the classes
056234a
@niden
[#14213] - Removed generated ext files
717bd19
@niden
[#14213] - Renamed Element to AbstractElement (Forms)
cc57558
@niden
[#14213] - Moved Security in its own folder
9a8969f
@niden
[#14213] - Moved Escaper in its own folder
ebb3816
@niden
[#14213] - Moved constants for Acl to Enum; Renamed abstract adapters
73865af
@niden
[#14213] - Moved crypt in its folder
756f3a9
@niden
[#14213] - Adjusted tests; Added Enum classes; Refactored Db/Acl abst…
806529a 
…ract classes
@niden
[#14213] - Fixed references
8602a6a
@niden
[#14213] - Fixing references; removed unecessary files
21b77e1
@niden
[#14213] - More correction references
2d4bf21
@niden
[#14213] - Another reference correction
ede0955
@niden
[#14213] - Renaming Dispatcher; Refactoring Image/Enum
824d934
@niden
[#14213] - Refactor Dispatcher with AbstractDispatcher
1dda3cc
@niden
[#14213] - Added enum class for the dispatcher constants
b59ac10
@niden
[#14213] - Removed redundant files; Added Dispatcher exception and co…
c861225 
…nstants
@niden
[#14213] - Exception corrections
5b73cfa
@niden
[#14213] - Fixed exception codes
5f8a4bd
@niden
[#14213] - References corrections
72de07f
@niden
[#14213] - More fixes for interfaces and class references
9471ba1
@niden
[#14213] - Corrected constants again
1aba34b
@niden
[#14213] - One more correction to the references
de1353c
@niden
[#14213] - Correcting more references
9cfa682
@niden
[#14213] - More references corrections
d88342a
@niden
[#14213] - Corrected Validation references
4378691
@niden
[#14213] - Correction to instanceof comparison
c7bae5e
@niden
[#14213] - Hopefully final corrections
aa6b5d2
niden added 14 commits July 1, 2019 21:43
@niden
[#14213] - Refactored abstract Model class
e24b0d4
@niden
[#14213] - Correct model references
a791e93
@niden
[#14213] - Fixed class references in test models
da4f429
@niden
[#14213] - More fixes to the model references
2456f7c
@niden
[#14213] - More corrections
b244eda
@niden
Revert "[#14213] - More corrections"
b708f49 
This reverts commit 1d535fd.
@niden
Revert "[#14213] - More fixes to the model references"
8733f42 
This reverts commit 0fc49ac.
@niden
Revert "[#14213] - Fixed class references in test models"
fe0e74e 
This reverts commit 053e808.
@niden
Revert "[#14213] - Correct model references"
852b987 
This reverts commit 1351b4a.
@niden
Revert "[#14213] - Refactored abstract Model class"
fb45bc8 
This reverts commit b3af058.
@niden
Revert "[#14213] - Refactoring the Model\Behavior abstract class"
a6975d7 
This reverts commit 0ba1f47.
@niden
Revert "[#14213] - Refactor Pdo/Dialect"
37ef9f2 
This reverts commit 96b3a10.
@niden
[#14213] - Changed Pdo to Abstract
13fed49
@niden
[#14213] - Updated changelog
1976bda
@niden niden added 4.0 enhancement Enhancement to the framework labels Jul 2, 2019
@niden
Copy link
Member Author

niden commented Jul 2, 2019

cc @sergeyklay

@codecov
Copy link

codecov bot commented Jul 2, 2019 •
edited
Loading

Codecov Report

Merging #14228 into 4.0.x will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14228      +/-   ##
==========================================
+ Coverage   66.32%   66.82%   +0.49%     
==========================================
  Files         475      445      -30     
  Lines      111553   102162    -9391     
==========================================
- Hits        73991    68267    -5724     
+ Misses      37562    33895    -3667
Impacted Files Coverage Δ
ext/phalcon/validation/validator/digit.zep.c 100% <0%> (ø) ⬆️
ext/phalcon/validation/validator/regex.zep.c 100% <0%> (ø) ⬆️
ext/phalcon/validation/validator/date.zep.c 100% <0%> (ø) ⬆️
ext/phalcon/validation/validator/identical.zep.c 90.38% <0%> (ø) ⬆️
ext/phalcon/validation/validator/creditcard.zep.c 79.34% <0%> (ø) ⬆️
ext/phalcon/validation/validator/exception.zep.c 100% <0%> (ø) ⬆️
ext/phalcon/validation/validator/presenceof.zep.c 100% <0%> (ø) ⬆️
ext/phalcon/validation/validator/inclusionin.zep.c 81.81% <0%> (ø) ⬆️
ext/phalcon/validation/validator/url.zep.c 100% <0%> (ø) ⬆️
ext/phalcon/validation/validator/between.zep.c 100% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4066b2b...98e7bca. Read the comment docs.

sergeyklay
sergeyklay approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@niden niden merged commit 14a9ab6 into phalcon:4.0.x Jul 4, 2019
@niden niden mentioned this pull request Jul 4, 2019
Closed
@niden niden deleted the T14213-abstract-classes branch September 12, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @sergeyklay