Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form::clear() now correctly clears single fields #14218

Merged
merged 3 commits into from
Jun 28, 2019
Merged

Form::clear() now correctly clears single fields #14218

merged 3 commits into from
Jun 28, 2019

Conversation

SidRoberts
Copy link
Contributor

@SidRoberts SidRoberts commented Jun 27, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • [-] I have created a PR for the documentation about this change

Small description of change:

Thanks

@SidRoberts SidRoberts changed the title Fixes 14217 Form::clear() now correctly clears single fields Jun 27, 2019
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #14218 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14218      +/-   ##
==========================================
+ Coverage   66.31%   66.31%   +<.01%     
==========================================
  Files         475      475              
  Lines      111767   111737      -30     
==========================================
- Hits        74115    74097      -18     
+ Misses      37652    37640      -12
Impacted Files Coverage Δ
ext/phalcon/forms/form.zep.c 72.97% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437470d...4559ba6. Read the comment docs.

@scrnjakovic
Copy link
Contributor

The issue I reported in #14217 is for 3.4.x version, I don't think it applies to 4.0 as Form::clear(), Element::clear(), Form::getValue() and Element::getValue() methods were re-written for 4.0 in #13500.

@SidRoberts
Copy link
Contributor Author

@scrnjakovic I've added another PR (#14219) for 3.4.x.

Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@sergeyklay sergeyklay merged commit ac770e5 into phalcon:4.0.x Jun 28, 2019
@sergeyklay
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants