Mvc\Model::__get() / __set() and related storage #14035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for Mvc\Model::save() Added tests for Mvc\Model::__set() Added tests for Mvc\Model::writeAttribute()
Added new related storages Modified __set(), __get(), getRelated() to use these related storages Modified save() to use these related storages with transaction handling Modified _getRelatedRecords() to use getRelated() when possible Reusable relations now cached and returned from the Model directly Non-reusable relation are not cached Fixed __set() to handle arrays correctly
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14035 +/- ##
==========================================
- Coverage 70.55% 68.84% -1.72%
==========================================
Files 479 470 -9
Lines 93433 95198 +1765
==========================================
- Hits 65924 65539 -385
- Misses 27509 29659 +2150
Continue to review full report at Codecov.
|
|
/cc @phalcon/framework-team |
SidRoberts
reviewed
May 5, 2019
SidRoberts
reviewed
May 5, 2019
Added missing comments
* Added variable types. * Whitespace. * Improved logic.
…n#14026) * Fixeing Config\Adapter\Ini notices when casting arrays * Fixed Phalcon\Config\Adapter\Ini() to handle arrays correctly * Update tests/_data/assets/config/config-with-constants.ini Co-Authored-By: zsilbi <[email protected]> * Fixeing Config\Adapter\Ini notices when casting arrays * Fixed Phalcon\Config\Adapter\Ini() to handle arrays correctly
Added tests for Mvc\Model::save() Added tests for Mvc\Model::__set() Added tests for Mvc\Model::writeAttribute()
added 3 commits
May 7, 2019 11:03
|
@CameronHall I checked SplObjectStorage but I dont't think it would be beneficial to use here. |
zsilbi
changed the title
|
@zsilbi can you please rebase this? This looks great. Awesome work! |
zsilbi
force-pushed
the
model-relation-storage-with-tests
branch
from
35c5299 to
d90459b
Compare
|
Thank you @zsilbi |
This was referenced May 11, 2019
niden
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Added new related storages
Modified __set(), __get(), getRelated() to use these related storages
Modified save() to use these related storages with transaction handling
Modified _getRelatedRecords() to use getRelated() when possible
Reusable relations are cached and returned from the Model directly
Non-reusable relations are not cached
Fixed __set() to handle arrays correctly
Added tests for Mvc\Model::save()
Added tests for Mvc\Model::__set()
Added tests for Mvc\Model::writeAttribute()
More tests needed...
Thanks,
zsilbi