Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Flash\Session::output() when session is empty #14024

Merged
merged 9 commits into from
Apr 29, 2019

Conversation

zsilbi
Copy link
Member

@zsilbi zsilbi commented Apr 29, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Fixed Phalcon\Flash\Session::output() not to throw an exception when there are no messages stored in session.

Thanks,
zsilbi

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #14024 into 4.0.x will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14024      +/-   ##
==========================================
+ Coverage   68.41%    68.5%   +0.08%     
==========================================
  Files         470      470              
  Lines       95150    95153       +3     
==========================================
+ Hits        65100    65183      +83     
+ Misses      30050    29970      -80
Impacted Files Coverage Δ
ext/phalcon/flash.zep.c 87.36% <0%> (+2.19%) ⬆️
ext/phalcon/flash/session.zep.c 42.39% <0%> (+40.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df2314...96741cc. Read the comment docs.

Jeckerson
Jeckerson previously approved these changes Apr 29, 2019
@niden niden merged commit 3f7f7b7 into phalcon:4.0.x Apr 29, 2019
@niden
Copy link
Member

niden commented Apr 29, 2019

Thank you @zsilbi

@zsilbi zsilbi deleted the flash-empty-session branch April 30, 2019 15:17
@niden niden added the documentation Documentation required label May 12, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Dec 2, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants