Skip to content

Phalcon\Translate\InterpolatorInterface now only accepts placeholder arrays #13939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Phalcon\Translate\InterpolatorInterface now only accepts placeholder arrays #13939

merged 2 commits into from
Apr 4, 2019

Conversation

SidRoberts
Copy link
Contributor

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • I updated the CHANGELOG

The parameter typehint was not strong enough. 😉

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #13939 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13939      +/-   ##
==========================================
- Coverage   67.63%   67.63%   -0.01%     
==========================================
  Files         469      469              
  Lines       94348    94337      -11     
==========================================
- Hits        63812    63804       -8     
+ Misses      30536    30533       -3
Impacted Files Coverage Δ
.../phalcon/translate/interpolator/indexedarray.zep.c 79.41% <0%> (-1.67%) ⬇️
...lcon/translate/interpolator/associativearray.zep.c 83.33% <0%> (-1.45%) ⬇️
...t/phalcon/mvc/collection/behavior/softdelete.zep.c 4.61% <0%> (+0.13%) ⬆️
ext/phalcon/mvc/model/behavior/softdelete.zep.c 78.4% <0%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ebc46...af474db. Read the comment docs.

Jeckerson
Jeckerson previously approved these changes Apr 3, 2019
niden
niden previously approved these changes Apr 4, 2019
@niden niden added breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework labels Apr 4, 2019
@niden niden dismissed stale reviews from Jeckerson and themself via af474db April 4, 2019 14:40
@niden niden merged commit 23f49d2 into phalcon:4.0.x Apr 4, 2019
@niden
Copy link
Member

niden commented Apr 4, 2019

Thank you @SidRoberts

@SidRoberts SidRoberts deleted the interpolator branch April 4, 2019 21:34
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants