Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed pointless property and variables from Volt compiler #13925

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Removed pointless property and variables from Volt compiler #13925

merged 3 commits into from
Apr 5, 2019

Conversation

SidRoberts
Copy link
Contributor

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • [-] I updated the CHANGELOG

Previously a variable was "cached" as a property.

CameronHall
CameronHall previously approved these changes Apr 1, 2019
@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #13925 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13925      +/-   ##
==========================================
- Coverage   67.63%   67.63%   -0.01%     
==========================================
  Files         469      469              
  Lines       94345    94340       -5     
==========================================
- Hits        63814    63809       -5     
  Misses      30531    30531
Impacted Files Coverage Δ
ext/phalcon/mvc/view/engine/volt/compiler.zep.c 66.34% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f49d2...d262a5d. Read the comment docs.

@niden
Copy link
Member

niden commented Apr 1, 2019

Can you add an entry in the CHANGELOG please @SidRoberts

@SidRoberts
Copy link
Contributor Author

@niden Changelog updated and rebased to avoid conflicts.

@niden niden added the enhancement Enhancement to the framework label Apr 5, 2019
@niden niden merged commit 814def6 into phalcon:4.0.x Apr 5, 2019
@niden
Copy link
Member

niden commented Apr 5, 2019

@SidRoberts Thank you!

@SidRoberts SidRoberts deleted the patch-4 branch April 5, 2019 16:49
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants