Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T13007 nativearray missing patch #13748

Merged
merged 13 commits into from
Jan 10, 2019
Merged

T13007 nativearray missing patch #13748

merged 13 commits into from
Jan 10, 2019

Conversation

niden
Copy link
Member

@niden niden commented Jan 9, 2019

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Better implementation for triggerError

Thanks

niden added 12 commits December 26, 2018 18:26
@niden
[4.0.x] - PHPCS fix
b7e3378
@niden
Merge remote-tracking branch 'upstream/master' into 4.0.x
abb3a4b 
* upstream/master:
  [4.0.x] - PHPCS fix
@niden
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
30f957e 
* upstream/4.0.x:
  Updated/Refactored Libmemcached tests
  #13459: Created test for issue and updated result checking
  Fixed #13497 returning "empty" values as `null`
@niden
[4.0.x] -
a828104
@niden
Revert "[4.0.x] -"
a438074 
This reverts commit a828104.
@niden
Revert "Revert "[4.0.x] -""
0e51dbc 
This reverts commit a438074.
@niden
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
1e94a04 
* upstream/4.0.x:
  Minor fixes in docblocks
@niden
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
2c14fd1 
* upstream/4.0.x:
  [#13007] - Correction to the changelog
  [#13007] - Updated the CHANGELOG
  [#13007] - Added notFound in the nativearray translate adapter
@niden
[4.0.x] - Code cleanup
5267edc
@niden
[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
a653bc7 
* upstream/4.0.x:
  Fixed change logs [ci skip]
  Fixed change logs [ci skip]
  Fixed Security\SecurityCest
  Fixed Libmemcached test
  Fixed PHP version at composer.json
  Actualize .gitignore
  Update dev dependencies
  Cleaned up no longer needed CI scripts
  Show test output in compact style
  Fixed code style for Session\ManagerCest
  Simplify session status check
  Update change log to add link to the #13520
  Do not run phpcs on PHP 7.3
  Do not interact with _SESSION if the session has not been started
  Fixed Session\Manager to not interact with _SESSION
  Fixed session adapters to properly implement SessionHandlerInterface::write
  fixed acl docblock
  4.0.x Tests code cleanup (#13734)
@niden
[4.0.x] - Added match to travis for issue branches
3991ffe
@niden
[#13007] - Corrected implementation of not found and added test
d07b839
@niden niden added the enhancement Enhancement to the framework label Jan 9, 2019
@niden niden changed the base branch from master to 4.0.x January 9, 2019 16:18
@niden
Copy link
Member Author

niden commented Jan 9, 2019

cc @sergeyklay

sergeyklay
sergeyklay previously approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (4.0.x@0572b97). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             4.0.x   #13748   +/-   ##
========================================
  Coverage         ?   65.53%           
========================================
  Files            ?      396           
  Lines            ?    88242           
  Branches         ?        0           
========================================
  Hits             ?    57832           
  Misses           ?    30410           
  Partials         ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0572b97...2214150. Read the comment docs.

@niden niden merged commit d2185b2 into phalcon:4.0.x Jan 10, 2019
@niden niden deleted the T13007-nativearray-missing-patch branch January 21, 2019 19:18
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay left review comments

Assignees
No one assigned
Labels
enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @sergeyklay