T12295 psr 11 #13681
Merged
T12295 psr 11 #13681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 4.0.x: (33 commits) [4.0.x] - Another correction to the test Corrected test Fixed tests Removed obsolete file Fixed the method signature PHPCS fix Fixed tabs Corrected tests [#12833] - Updated the changelog [#12833] - Deleted obsolete tests [#12833] - PHPCS fixes [#12833] - Corrections to the manager and test (cleanup superglobal on destroy) [#12833] - Fixes and corrections to the tests [#12833] - Corrections to the tests and files adapter [#12833] - Fixed tests; Added exception in session for non valid handler [#12833] - Full tests for Session\Adapter; Adjustments to the environment; Test stubs [#12833] - Corrections and adding files adapter tests [#12833] - Correction to the redis session adapter; Work on the test traits [#12833] - Setup default session_save path to /tmp [#12833] - Cleanup for tests ...
|
cc @sergeyklay |
sergeyklay
reviewed
Dec 22, 2018
| $container = new Di(); | ||
| $class = ContainerInterface::class; | ||
| $actual = new Container($container); | ||
| $I->assertInstanceOf($class, $actual); |
There was a problem hiding this comment.
Can this be simplified, eg
$I->assertInstanceOf(ContainerInterface::class, new Container(new Di));There was a problem hiding this comment.
I like to keep things separate in the test; It makes reading a bit easier and discourages people writing an assertion that is long and difficult to understand.
sergeyklay
reviewed
Dec 22, 2018
phalcon/container.zep
Outdated
| use Psr\Container\ContainerInterface; | ||
| use Phalcon\DiInterface; | ||
|
|
||
| final class Container implements ContainerInterface |
There was a problem hiding this comment.
Do we really need this as final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Created a new "proxy" class
Phalcon\Container. This class implements PSR-11 and can be used instead of theDIcontainer. Note that you still have to create the DI container and set all services into it and then inject that container in this container (I got dizzy writing this).This is not the full implementation, a "proxy" for now - more on that in a future version.
Thanks