Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T12921 remove session from di factory #13667

Merged
merged 6 commits into from
Dec 18, 2018
Merged

T12921 remove session from di factory #13667

merged 6 commits into from
Dec 18, 2018

Conversation

niden
Copy link
Member

@niden niden commented Dec 17, 2018

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Removed the session service from the FactoryDefault container

Thanks

@niden niden requested a review from sergeyklay December 17, 2018 21:16
@niden niden added enhancement Enhancement to the framework breaks bc Functionality that breaks Backwards Compatibility labels Dec 17, 2018
@niden
Copy link
Member Author

niden commented Dec 17, 2018

cc @sergeyklay

sergeyklay
sergeyklay suggested changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was 1 failure:

Phalcon\Test\Unit\Di\FactoryDefault\ConstructCest::diFactoryDefaultConstructServices

Failed asserting that 19 matches expected 21

sergeyklay
sergeyklay suggested changes Dec 17, 2018
View reviewed changes
CHANGELOG-4.0.md Outdated Show resolved Hide resolved
niden added 2 commits December 17, 2018 19:16
@niden
[#12921] - Merge branch '4.0.x' into T12921-remove-session-from-di-fa…
684f316 
…ctory

* 4.0.x:
  [#13061] - Updated changelog
  [#13061] - Added test for the interface
  [#13061] - Aligned interfaces
  [#13639] - Updated the changelog
  [#13639] - Corrected tests
  [#13639] - Corrected tests
  [#13639] - Renamed Acl\Role to Acl\Operation
  [#13639] - Renamed Acl\Resource to Acl\Subject
@niden
[#12921] - Changes to the changelog; corrected test
cc0ad96
@niden
Copy link
Member Author

niden commented Dec 18, 2018

@sergeyklay fixed issues

@niden niden merged commit cc0ad96 into phalcon:4.0.x Dec 18, 2018
@niden niden deleted the T12921-remove-session-from-di-factory branch January 21, 2019 19:19
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @sergeyklay