[4.0.x] Pagination supports optional aliases and Phalcon\Mvc\Model\Query\Builder supports bind params #13653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niden
requested changes
Dec 11, 2018
| @@ -0,0 +1,70 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Will need to refactor this a bit after we add it to the main repo. I will generate test stubs to split all the methods and make tests shorter. a todo for later.
There was a problem hiding this comment.
No worries. In future, would you rather we generate the stubs when adding new classes? If so, how do we do that?
There was a problem hiding this comment.
Those are generated with zephir stubs
|
Looking good! |
Created tentative test for Issue phalcon#13552
CameronHall
force-pushed
the
feature/paginator-repository
branch
from
5fe36d5 to
217518d
Compare
|
@niden changes have been made as requested :) |
niden
approved these changes
Dec 12, 2018
|
@CameronHall Thank you! |
This was referenced Dec 12, 2018
sergeyklay
reviewed
Dec 12, 2018
| @@ -54,3 +54,5 @@ php_test_results_*.txt | |||
| docker-compose.yml | |||
| build/gccarch | |||
| tests/_cache | |||
| .zephir/ | |||
| .temp/ | |||
There was a problem hiding this comment.
@CameronHall Zephir >= 0.11 uses .zephir and Zephir < 0.11 .temp
There was a problem hiding this comment.
@sergeyklay I'll remove .temp in the next PR.
sergeyklay
reviewed
Dec 12, 2018
niden
added
4.0
new feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Phalcon\Paginator\RepositoryInterfacefor repository the current state ofpaginatorand also optional sets the aliases for properties repository.Phalcon\Mvc\Model\Query\Builder. The Query Builder has the same methods asPhalcon\Mvc\Model\Query;getBindParams,setBindParams,getBindTypesandsetBindTypes. #13368It is worth noting I made a few changes between the original PR #10985 and this one. I've updated all the property names to what they were changes to in #13492. I also turfed the
totalPagesproperty as it was made redundant by the pre-existing propertylast.All of the pagination adapter constructors received a spring clean as well.
Thanks