Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HTML escaping to Phalcon\Tag::textArea #13624

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Added HTML escaping to Phalcon\Tag::textArea #13624

merged 1 commit into from
Nov 29, 2018

Conversation

CameronHall
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change: Textarea content is passed through htmlspecialchars before it's outputted to prevent XSS as explained in #12428.

Thanks

@CameronHall CameronHall changed the base branch from master to 4.0.x November 28, 2018 11:51
@CameronHall CameronHall changed the title Bugfix/textarea escaping Added HTML escaping to Phalcon\Tag::textArea Nov 28, 2018
@niden niden merged commit 9c3a70f into phalcon:4.0.x Nov 29, 2018
@niden
Copy link
Member

niden commented Nov 29, 2018

@CameronHall Thank you!

@sergeyklay sergeyklay added the breaks bc Functionality that breaks Backwards Compatibility label Nov 29, 2018
@sergeyklay sergeyklay added this to the 4.0.0 milestone Nov 29, 2018
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required Bug - Low labels Oct 13, 2019
@CameronHall CameronHall deleted the bugfix/textarea-escaping branch October 24, 2019 11:36
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees
No one assigned
Labels
breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CameronHall @niden @sergeyklay