Fixes #11759 and deletes expired keys #13621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
previously requested changes
Nov 28, 2018
CameronHall
force-pushed
the
bugfix/expire-file-cache
branch
from
2538588 to
740ba61
Compare
|
Updated as requested @sergeyklay |
niden
approved these changes
Nov 29, 2018
|
@CameronHall Thank you! |
niden
added
4.0
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change: Reviving a dormant PR. This change should make File cache start behaving like it the
memcachedorrediscaches in that it handles lifetimes appropriately instead of when lifetimes are negative. It's explained in detail in the #11759.Thanks