Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasHeader in Response #13570

Merged
merged 14 commits into from
Nov 3, 2018
Merged

Add hasHeader in Response #13570

merged 14 commits into from
Nov 3, 2018

Conversation

niden
Copy link
Member

@niden niden commented Nov 2, 2018

Hello!

  • Type: new feature
  • Link to issue: PR-12189

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Added hasHeader in Phalcon\Http\Response to allow checking for a valid header existence

Thanks

@niden niden requested a review from sergeyklay November 2, 2018 22:20
@niden niden self-assigned this Nov 2, 2018
@niden niden added enhancement Enhancement to the framework breaks bc Functionality that breaks Backwards Compatibility labels Nov 2, 2018
@niden niden added this to the 4.0.0 milestone Nov 2, 2018
@niden
Copy link
Member Author

niden commented Nov 2, 2018

cc @sergeyklay

@niden niden mentioned this pull request Nov 2, 2018
Closed
sergeyklay
sergeyklay reviewed Nov 3, 2018
View reviewed changes
CHANGELOG-4.0.md Outdated Show resolved Hide resolved
sergeyklay
sergeyklay previously approved these changes Nov 3, 2018
View reviewed changes
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except minor things)

@niden niden merged commit 76d2ae1 into phalcon:4.0.x Nov 3, 2018
@niden niden deleted the PR12189-no-header-request-should-return-null-4 branch November 3, 2018 22:43
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden removed this from the 4.0.0 milestone Oct 13, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay left review comments

Assignees

@niden niden

Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @sergeyklay