Reorganized/cleaned up Session classes #13538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/SidRoberts/cphalcon into SidRoberts-v4-collection-validation * 'v4-collection-validation' of https://github.com/SidRoberts/cphalcon: Collections now use the Validation component.
* SidRoberts-v4-collection-validation: Collections now use the Validation component.
* upstream/4.0.x: Renamed notSave event to notSaved in Collection.
|
cc @sergeyklay |
sergeyklay
suggested changes
Oct 19, 2018
phalcon/session/adapter.zep
Outdated
| | | | ||
| | For the full copyright and license information, please view the LICENSE | | ||
| | file that was distributed with this source code. | | ||
| +-------------------------------------------------------------------------+ |
There was a problem hiding this comment.
Can we use a bit more simple format for this?
/**
* This file is part of the Phalcon.
*
* (c) Phalcon Team <[email protected]>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
|
Also add this method from here - #13535 |
|
@Jurigag @sergeyklay Those issues will be dealt with the next PR. I am consolidating a few issues in this PR such as #11341 #12833 #13535 and PR10883 |
niden
added
4.0
breaks bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Reorganized the methods and properties in alphabetical order (public, protected, private). Added a new copyright notice at the top of each file
Thanks