Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13492] Changes to the paginator #13494

Merged
merged 10 commits into from
Oct 10, 2018
Merged

[#13492] Changes to the paginator #13494

merged 10 commits into from
Oct 10, 2018

Conversation

niden
Copy link
Member

@niden niden commented Sep 19, 2018

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:
Changes to the paginator as described in the linked issue.

  • Added proxy method paginate() to do the same thing as getPaginate().
  • Added previous property to replace before after v4.0
  • Added deprecated in docblocks for total_items, before and getPaginate()

@niden niden requested review from sergeyklay and Jurigag September 19, 2018 21:33
@niden
Updated the changelog
d8ac76d
@niden
Merge branch '4.0.x' into 4.0.x
b597f18
@niden
Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
684487f 
* upstream/4.0.x: (315 commits)
  Regenerated build
  Regenerated ext
  Removed no longer used local variable from router.zep
  Update CONTRIBUTING.md [ci-skip]
  Removed configure.ac
  Fix issue with validation on locales where comma used (#13457)
  default parameter value matches the type
  removes incorrect mysql tinyblob bindtype
  Regenerated build
  Used latest Zephir
  Update change log
  Update license
  changelog 4.0
  Test for queryKeys with prefix and statsKey
  Fix issue with retuned keys by queryKeys
  Update backers & sponsors [ci-skip]
  use varuable "ns" instead of scale value "\\"
  Spelling error
  Update docs [ci skip]
  Install psr extension on AppVeyor
  ...
@niden
Merge branch '4.0.x' of git://github.com/niden/cphalcon into 4.0.x
6ec3df6 
* '4.0.x' of git://github.com/niden/cphalcon:
@niden niden merged commit eb26399 into phalcon:4.0.x Oct 10, 2018
@sergeyklay sergeyklay added the new feature request Planned Feature or New Feature Request label Oct 19, 2018
@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 19, 2018
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay Awaiting requested review from sergeyklay

@Jurigag Jurigag Awaiting requested review from Jurigag

Assignees
No one assigned
Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @sergeyklay