allowEmpty can be populated with the list of what we consider 'empty'. The validation only will stop if the empty validation returns true.

[gguridi]

Hello!

• Type: bug fix | new feature
• Link to issue: Validator option to skip all validation if field is not present #12106

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the Contributing Guidelines?
• I have checked that another pull request for this purpose does not exist.
• I wrote some tests for this PR.

Small description of change:

Added the possibility to specify in allowEmpty option what we consider 'empty'. Fixed the behaviour so only in case it returns true we move to the next validation. Added recursivity in the preChecking method so we don't duplicate code. Updated changelog.

• allowEmtpy = true (this means that everything that evaluates to empty is ok)
• allowEmpty = ['', null] (this means that empty only means empty string and null, false and 0 won't evaluate as empty).

I've added a pull request with this change. The benefits are:

• Backwards compatible.
• Flexible, we can specify 'unknown', 'empty' or -1 as empty values in case we are using a shitty api.

An improvement also added in the pull request is that only if the allowEmpty validation is true the validation will stop there, in case of false it will continue with the next validators.

Thanks

---

This change is 

[sergeyklay]

Thanks

[someson]

what if

    // ...
    allowEmpty => ['', null, new RawValue('NULL')],

?

new RawValue('NULL') === new RawValue('NULL') → false

I have to prefill the entity already on form-level (save/update), not model-level.
Extended form handler:

    private function _nullableValue(Model $entry, string $fieldName, $value)
    {
        $metaData = $entry->getModelsMetaData();
        $attributes = $metaData->getNotNullAttributes($entry);
        return \in_array($fieldName, $attributes, true) ? $value : new RawValue('NULL');
    }

Model:

    public function validation(): bool
    {
        // ...
        $validation->add('vat', new Numericality(['allowEmpty' => [new RawValue('NULL')]]));

[sergeyklay]

@someson could you please create a PR with test which fails?

[someson]

@sergeyklay, yeah, I'll try :)