Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.x Additional DI test #12312

Closed
wants to merge 8 commits into from
Closed

3.0.x Additional DI test #12312

wants to merge 8 commits into from

Conversation

Zaszczyk
Copy link
Contributor

@Zaszczyk Zaszczyk commented Oct 12, 2016

It is additional tests which cause segmentation fault described in #12299

Thank you for wanting to contribute to Phalcon.

Before you submit a Pull Request, please bear in mind that PRs must be made on a
version branch (eg. 3.0.x). master marks the latest stable release so PRs
targeting master will be rejected.

Please also check the following points are being met:

  • Make sure that the PR passes in Travis CI to make the process more efficient.
  • Only use tabs for indentation.
  • if needed, rebase to the proper branch before submitting your pull request.
    If it doesn't merge cleanly with master you may be asked to rebase your changes.
  • Don't put submodule updates in your pull request unless they are to landed commits.
  • Add tests relevant to the fixed bug or new feature. See our testing guide for
    more information.
  • Phalcon 2 is written in Zephir, please do not submit commits that modify C generated
    files directly or those whose functionality/fixes are implemented in the C
    programming language
  • Remove any change to ext/kernel / *.zep.c / *.zep.h files before submitting the PR

@sergeyklay sergeyklay modified the milestone: 3.0.3 Oct 14, 2016
@sergeyklay sergeyklay modified the milestones: 3.0.3, 3.0.x Nov 27, 2016
@sergeyklay sergeyklay modified the milestones: 3.0.x, 3.1.0 Dec 18, 2016
@sergeyklay sergeyklay modified the milestones: 3.1.x, 3.1.0 Mar 15, 2017
@sergeyklay sergeyklay closed this Mar 22, 2017
@sergeyklay sergeyklay modified the milestones: 3.2.x, 3.2.0 Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants